annotate cdg-hybrid/sap-inline/cl_inline.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
212
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /***
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 ;*** File : cl_inline.h
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 ;*** Creation : Wed Mar 11 09:58:09 CST 2009
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 ;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 ;*** Copyright : (c) Texas Instruments AG, Berlin Germany 2002
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 ;*** Document Type : Service Access Point Specification
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 ;*** Document Name : cl
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 ;*** Document No. : 8010.149.04.012
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 ;*** Document Date : 2004-06-08
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 ;*** Document Status: SUBMITTED
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 ;*** Document Author: rpk
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 ;*** !!! THIS INCLUDE FILE WAS GENERATED AUTOMATICALLY, DO NOT MODIFY !!!
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 ***/
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 #ifndef _CL_INLINE_H_
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 #define _CL_INLINE_H_
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 extern void cl_nwrl_set_sgsn_release ( U8 sgsn_rel );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 extern U8 cl_nwrl_get_sgsn_release ( void );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 extern U8 cl_qos_convert_r99_to_r97 ( T_PS_qos_r99 *src_qos_r99, T_PS_qos_r97 *dst_qos_r97 );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 extern U8 cl_qos_convert_r97_to_r99 ( T_PS_qos_r97 *src_qos_r97, T_PS_qos_r99 *dst_qos_r99 );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 #endif /* !_CL_INLINE_H_ */