FreeCalypso > hg > fc-magnetite
annotate src/gpf2/tst/idle.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | cd37d228dae0 |
children |
rev | line source |
---|---|
294
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 +------------------------------------------------------------------------------ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 | File: idle.h |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 +------------------------------------------------------------------------------ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 | Copyright Texas Instruments 2002 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 | All rights reserved. |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 | |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 +------------------------------------------------------------------------------ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 | Purpose: Definitions for the IDLE entity. |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 | $Identity:$ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 +------------------------------------------------------------------------------ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 #ifndef IDLE_H |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 #define IDLE_H |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 /*==== INCLUDES ==============================================================*/ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 /*==== CONSTS ================================================================*/ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 #ifdef VSI_CALLER |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 #undef VSI_CALLER |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 #define VSI_CALLER idle_handle, |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 #define VSI_CALLER_SINGLE idle_handle |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 #endif |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 #define hCommTST idle_hCommTST /* Communication handle to TST */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
29 #define IDLE_REQ 0x00000010 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
30 #define IDLE_CNF 0x00010010 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
31 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
32 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
33 #ifndef __T_IDLE_CNF__ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
34 #define __T_IDLE_CNF__ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
35 typedef struct |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
36 { |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
37 U8 dummy; /*< 0: 1> */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
38 } T_IDLE_CNF; |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
39 #endif |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
40 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
41 #ifndef __T_IDLE_REQ__ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
42 #define __T_IDLE_REQ__ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
43 typedef struct |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
44 { |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
45 U8 dummy; /*< 0: 1> */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
46 } T_IDLE_REQ; |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
47 #endif |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
48 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
49 /*==== TYPES =================================================================*/ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
50 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
51 /*==== EXPORTS ===============================================================*/ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
52 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
53 #ifdef IDLE_PEI_C |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
54 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
55 /* Communication handles */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
56 T_HANDLE idle_handle; |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
57 T_HANDLE hCommTST = VSI_ERROR; |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
58 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
59 #else /* IDLE_PEI_C */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
60 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
61 extern T_HANDLE idle_handle; |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
62 extern T_HANDLE hCommTST; |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
63 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
64 #endif /* IDLE_PEI_C */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
65 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
66 #endif /* IDLE_H */ |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
67 |
cd37d228dae0
src/gpf2/{misc,tst}: import from TCS211 semi-src
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
68 /*==== END OF FILE ===========================================================*/ |