FreeCalypso > hg > fc-magnetite

view src/gpf2/tst/idle.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents cd37d228dae0
children
line wrap: on
line source

/*
+------------------------------------------------------------------------------
|  File:       idle.h
+------------------------------------------------------------------------------
|                 Copyright Texas Instruments 2002
|                 All rights reserved.
|
+------------------------------------------------------------------------------
| Purpose:     Definitions for the IDLE entity.
| $Identity:$
+------------------------------------------------------------------------------
*/

#ifndef IDLE_H
#define IDLE_H

/*==== INCLUDES ==============================================================*/

/*==== CONSTS ================================================================*/

#ifdef VSI_CALLER
 #undef VSI_CALLER
 #define VSI_CALLER        idle_handle,
 #define VSI_CALLER_SINGLE idle_handle
#endif

#define hCommTST          idle_hCommTST   /* Communication handle to TST       */

#define IDLE_REQ   0x00000010
#define IDLE_CNF   0x00010010


#ifndef __T_IDLE_CNF__
#define __T_IDLE_CNF__
typedef struct
{
  U8                        dummy;                       /*<  0:  1>                              */
} T_IDLE_CNF;
#endif

#ifndef __T_IDLE_REQ__
#define __T_IDLE_REQ__
typedef struct
{
  U8                        dummy;                       /*<  0:  1>                              */
} T_IDLE_REQ;
#endif

/*==== TYPES =================================================================*/

/*==== EXPORTS ===============================================================*/

#ifdef IDLE_PEI_C

/* Communication handles */
T_HANDLE                 idle_handle;
T_HANDLE                 hCommTST = VSI_ERROR;

#else /* IDLE_PEI_C */

extern T_HANDLE          idle_handle;
extern T_HANDLE          hCommTST;

#endif /* IDLE_PEI_C */

#endif /* IDLE_H */

/*==== END OF FILE ===========================================================*/