FreeCalypso > hg > fc-tourmaline
view src/cs/services/audio/audio_vm_amr.c @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/****************************************************************************/ /* */ /* File Name: audio_vm_amr.c */ /* */ /* Purpose: This file contains all the functions used to manage the */ /* Voice Memorization AMR. */ /* */ /* Version 0.1 */ /* */ /* Date Modification */ /* ------------------------------------ */ /* 2 November 2002 Create */ /* */ /* Author */ /* Frederic Turgis */ /* */ /* (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved*/ /****************************************************************************/ #include "rv/rv_defined_swe.h" #ifdef RVM_AUDIO_MAIN_SWE #ifndef _WINDOWS #include "config/swconfig.cfg" #include "config/sys.cfg" #include "config/chipset.cfg" #endif /* include the usefull L1 header */ #include "l1_confg.h" #if (L1_VOICE_MEMO_AMR) #include "rv/rv_general.h" #include "rvm/rvm_gen.h" #include "audio/audio_features_i.h" #include "audio/audio_ffs_i.h" #include "audio/audio_api.h" #include "audio/audio_structs_i.h" #include "audio/audio_var_i.h" #include "audio/audio_messages_i.h" #include "rvf/rvf_target.h" #include "audio/audio_const_i.h" #include "audio/audio_error_hdlr_i.h" /* include the usefull L1 header */ #define BOOL_FLAG #define CHAR_FLAG #include "l1_types.h" #include "l1audio_cust.h" #include "l1audio_msgty.h" #include "l1audio_signa.h" /********************************************************************************/ /* */ /* Function Name: audio_voice_memo_amr_message_switch */ /* */ /* Purpose: Manage the message supply between the voice memo play and the */ /* voice memo record AMR */ /* */ /* Input Parameters: */ /* start or stop message from the voice memo features */ /* */ /* Output Parameters: */ /* index of the manager */ /* */ /* Note: */ /* None. */ /* */ /* Revision History: */ /* None. */ /* */ /********************************************************************************/ #if (AUDIO_MEM_MANAGER) UINT8 audio_voice_memo_amr_memory_message_switch (T_RV_HDR *p_message) { switch (p_message->msg_id) { #if(AUDIO_NEW_FFS_MANAGER) case AUDIO_VM_AMR_RECORD_TO_FFS_START_REQ: case AUDIO_VM_AMR_RECORD_TO_FFS_STOP_REQ: { return(AUDIO_VM_AMR_RECORD); } break; #endif #if(AUDIO_RAM_MANAGER) case AUDIO_VM_AMR_RECORD_TO_RAM_START_REQ: case AUDIO_VM_AMR_RECORD_TO_RAM_STOP_REQ: { return(AUDIO_VM_AMR_RECORD); } break; #endif #if (AUDIO_NEW_FFS_MANAGER) case AUDIO_VM_AMR_PLAY_FROM_FFS_START_REQ: case AUDIO_VM_AMR_PLAY_FROM_FFS_STOP_REQ: { return(AUDIO_VM_AMR_PLAY); } break; #endif #if (AUDIO_RAM_MANAGER) case AUDIO_VM_AMR_PLAY_FROM_RAM_START_REQ: case AUDIO_VM_AMR_PLAY_FROM_RAM_STOP_REQ: { return(AUDIO_VM_AMR_PLAY); } break; #endif #if (AUDIO_MEM_MANAGER) /* check channel_id is the one given by driver initialization*/ case AUDIO_MEM_STATUS_MSG: { /* check VM AMR is active for the given channel_id */ if ((p_audio_gbl_var->audio_vm_amr_record.state != AUDIO_IDLE) && ( ((T_AUDIO_MEM_STATUS *)p_message)->channel_id == p_audio_gbl_var->audio_vm_amr_record.channel_id)) return(AUDIO_VM_AMR_RECORD); if ((p_audio_gbl_var->audio_vm_amr_play.state != AUDIO_IDLE) && ( ((T_AUDIO_MEM_STATUS *)p_message)->channel_id == p_audio_gbl_var->audio_vm_amr_play.channel_id)) return(AUDIO_VM_AMR_PLAY); return(AUDIO_VM_AMR_NONE); } break; #endif /* driver init => check session_id is VM AMR */ case AUDIO_DRIVER_INIT_STATUS_MSG: { UINT8 session_id = ((T_AUDIO_DRIVER_INIT_STATUS *)p_message)->session_id; /* session_id is VM AMR */ if ( (session_id == AUDIO_VM_AMR_PLAY_SESSION_ID)&& (p_audio_gbl_var->audio_vm_amr_play.state != AUDIO_IDLE)) { return (AUDIO_VM_AMR_PLAY); } if ( (session_id == AUDIO_VM_AMR_RECORD_SESSION_ID)&& (p_audio_gbl_var->audio_vm_amr_record.state != AUDIO_IDLE)) { return (AUDIO_VM_AMR_RECORD); } return(AUDIO_VM_AMR_NONE); } break; default: return(AUDIO_VM_AMR_NONE); break; } /* switch */ } #endif // #if (AUDIO_MEM_MANAGER) #endif /* L1_VOICE_MEMO_AMR */ #endif /* RVM_AUDIO_MAIN_SWE */