annotate target-utils/simtest/reset.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 0a2e3fd156ed
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
458
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 #include <sys/types.h>
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 #include <strings.h>
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 #include "types.h"
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 #include "simregs.h"
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 extern u16 conf1_reg;
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 void
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 cmd_reset(argbulk)
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 char *argbulk;
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 {
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 char *argv[2];
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 if (parse_args(argbulk, 1, 1, argv, 0) < 0)
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 return;
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 if (!strcmp(argv[0], "0"))
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 SIMREGS.conf1 = conf1_reg &= ~SIM_CONF1_SRSTLEV;
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 else if (!strcmp(argv[0], "1"))
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 SIMREGS.conf1 = conf1_reg |= SIM_CONF1_SRSTLEV;
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 else
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 printf("ERROR: \"0\" or \"1\" argument expected\n");
0a2e3fd156ed simtest: reset implemented
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 }