FreeCalypso > hg > freecalypso-tools
view target-utils/simtest/reset.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 0a2e3fd156ed |
children |
line wrap: on
line source
#include <sys/types.h> #include <strings.h> #include "types.h" #include "simregs.h" extern u16 conf1_reg; void cmd_reset(argbulk) char *argbulk; { char *argv[2]; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (!strcmp(argv[0], "0")) SIMREGS.conf1 = conf1_reg &= ~SIM_CONF1_SRSTLEV; else if (!strcmp(argv[0], "1")) SIMREGS.conf1 = conf1_reg |= SIM_CONF1_SRSTLEV; else printf("ERROR: \"0\" or \"1\" argument expected\n"); }