FreeCalypso > hg > freecalypso-tools
view rvinterf/lowlevel/format_fc.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 8fc3b72eb2c6 |
children |
line wrap: on
line source
/* * This module has been split off from format.c; it implements the decoding * of those Rx packet types which have been invented in FreeCalypso. */ #include <sys/types.h> #include <stdio.h> #include <string.h> #include <strings.h> #include "../include/pktmux.h" #include "../include/limits.h" extern u_char rxpkt[]; extern size_t rxpkt_len; extern void output_cont_logpref(); void print_ati_output() { char fmtbuf[MAX_PKT_FROM_TARGET*4+2]; strcpy(fmtbuf, "ATI: "); safe_print_trace(rxpkt + 1, (int)rxpkt_len - 1, fmtbuf + 5); output_line(fmtbuf); } void print_fc_lld_msg() { char fmtbuf[MAX_PKT_FROM_TARGET*4+2]; strcpy(fmtbuf, "LLD: "); safe_print_trace(rxpkt + 1, (int)rxpkt_len - 1, fmtbuf + 5); output_line(fmtbuf); } void print_tch_output_raw() { output_line("Rx TCH packet"); packet_hex_dump(rxpkt, (unsigned) rxpkt_len, output_cont_logpref); } void report_extui_packet() { char fmtbuf[80]; sprintf(fmtbuf, "LCD OUT: row %u col %u-%u", rxpkt[1], rxpkt[2], rxpkt[2] + (rxpkt_len - 3) / 2 - 1); output_line(fmtbuf); }