view rvinterf/lowlevel/format_fc.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 8fc3b72eb2c6
children
line wrap: on
line source

/*
 * This module has been split off from format.c; it implements the decoding
 * of those Rx packet types which have been invented in FreeCalypso.
 */

#include <sys/types.h>
#include <stdio.h>
#include <string.h>
#include <strings.h>
#include "../include/pktmux.h"
#include "../include/limits.h"

extern u_char rxpkt[];
extern size_t rxpkt_len;

extern void output_cont_logpref();

void
print_ati_output()
{
	char fmtbuf[MAX_PKT_FROM_TARGET*4+2];

	strcpy(fmtbuf, "ATI: ");
	safe_print_trace(rxpkt + 1, (int)rxpkt_len - 1, fmtbuf + 5);
	output_line(fmtbuf);
}

void
print_fc_lld_msg()
{
	char fmtbuf[MAX_PKT_FROM_TARGET*4+2];

	strcpy(fmtbuf, "LLD: ");
	safe_print_trace(rxpkt + 1, (int)rxpkt_len - 1, fmtbuf + 5);
	output_line(fmtbuf);
}

void
print_tch_output_raw()
{
	output_line("Rx TCH packet");
	packet_hex_dump(rxpkt, (unsigned) rxpkt_len, output_cont_logpref);
}

void
report_extui_packet()
{
	char fmtbuf[80];

	sprintf(fmtbuf, "LCD OUT: row %u col %u-%u", rxpkt[1], rxpkt[2],
		rxpkt[2] + (rxpkt_len - 3) / 2 - 1);
	output_line(fmtbuf);
}