view target-utils/lunadrv/regcmd.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 36e6a1ff9608
children
line wrap: on
line source

/*
 * Handy commands for reading and writing LCD controller registers.
 */

#include <sys/types.h>
#include "types.h"
#include "luna.h"

void
cmd_rd(argbulk)
	char *argbulk;
{
	char *argv[2];
	u_long regno;

	if (parse_args(argbulk, 1, 1, argv, 0) < 0)
		return;
	if (parse_hexarg(argv[0], 4, &regno) < 0) {
	    printf("ERROR: regno argument must be a valid 16-bit hex word\n");
		return;
	}
	LCD_IR = regno;
	printf("%04X\n", LCD_DR);
}

void
cmd_wr(argbulk)
	char *argbulk;
{
	char *argv[3];
	u_long regno, value;

	if (parse_args(argbulk, 2, 2, argv, 0) < 0)
		return;
	if (parse_hexarg(argv[0], 4, &regno) < 0) {
	    printf("ERROR: regno argument must be a valid 16-bit hex word\n");
		return;
	}
	if (parse_hexarg(argv[1], 4, &value) < 0) {
	    printf("ERROR: value argument must be a valid 16-bit hex word\n");
		return;
	}
	LCD_IR = regno;
	LCD_DR = value;
}