view target-utils/lunadrv/regcmd.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 36e6a1ff9608
children
line wrap: on
line source

/*
 * Handy commands for reading and writing LCD controller registers.
 */

#include <sys/types.h>
#include "types.h"
#include "luna.h"

void
cmd_rd(argbulk)
	char *argbulk;
{
	char *argv[2];
	u_long regno;

	if (parse_args(argbulk, 1, 1, argv, 0) < 0)
		return;
	if (parse_hexarg(argv[0], 4, &regno) < 0) {
	    printf("ERROR: regno argument must be a valid 16-bit hex word\n");
		return;
	}
	LCD_IR = regno;
	printf("%04X\n", LCD_DR);
}

void
cmd_wr(argbulk)
	char *argbulk;
{
	char *argv[3];
	u_long regno, value;

	if (parse_args(argbulk, 2, 2, argv, 0) < 0)
		return;
	if (parse_hexarg(argv[0], 4, &regno) < 0) {
	    printf("ERROR: regno argument must be a valid 16-bit hex word\n");
		return;
	}
	if (parse_hexarg(argv[1], 4, &value) < 0) {
	    printf("ERROR: value argument must be a valid 16-bit hex word\n");
		return;
	}
	LCD_IR = regno;
	LCD_DR = value;
}