view libpwon/readconf.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents ab54957dbe35
children
line wrap: on
line source

#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>

static char conf_file_pathname[] = "/opt/freecalypso/bootctrl.conf";

#define	MAX_BOOTCTRL_CONF_LINE	510

char bootctrl_pwon_cmd[MAX_BOOTCTRL_CONF_LINE+1];
int bootctrl_etmoff_mode;

find_bootctrl_entry(soughtname)
	char *soughtname;
{
	FILE *inf;
	char linebuf[MAX_BOOTCTRL_CONF_LINE+2];
	int lineno;
	char *cp, *np;

	if (bootctrl_check_duart28c(soughtname))
		return(0);
	if (!strcmp(soughtname, "etmoff")) {
		bootctrl_etmoff_mode = 1;
		return(0);
	}
	inf = fopen(conf_file_pathname, "r");
	if (!inf) {
		perror(conf_file_pathname);
		return(-1);
	}
	for (lineno = 1; fgets(linebuf, sizeof linebuf, inf); lineno++) {
		cp = index(linebuf, '\n');
		if (!cp) {
			fprintf(stderr,
				"%s line %d: too long or missing newline\n",
				conf_file_pathname, lineno);
			fclose(inf);
			return(-1);
		}
		*cp = '\0';
		for (cp = linebuf; isspace(*cp); cp++)
			;
		if (*cp == '\0' || *cp == '#')
			continue;
		for (np = cp; *cp && !isspace(*cp); cp++)
			;
		if (!*cp) {
invalid_syntax:		fprintf(stderr, "%s line %d: invalid syntax\n",
				conf_file_pathname, lineno);
			fclose(inf);
			return(-1);
		}
		*cp++ = '\0';
		while (isspace(*cp))
			cp++;
		if (*cp == '\0' || *cp == '#')
			goto invalid_syntax;
		if (!strcmp(np, soughtname)) {
			strcpy(bootctrl_pwon_cmd, cp);
			fclose(inf);
			return(0);
		}
	}
	fclose(inf);
	fprintf(stderr, "error: no \"%s\" entry found in %s\n", soughtname,
		conf_file_pathname);
	return(-1);
}