FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/piradccal.c @ 1011:6d9b10633f10 default tip
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 886f65760d09 |
children |
line wrap: on
line source
/* * This module is linked into fc-tmsync and implements a command for * retrieving Pirelli's VBAT ADC calibration. */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include "localtypes.h" #include "exitcodes.h" get_pirelli_vbat_cal() { u_char bytes[2]; int a, b; int rc; rc = do_memory_read(0x027F06E5, bytes, 2); if (rc) return(rc); a = bytes[0] | (bytes[1] << 8); rc = do_memory_read(0x027F06F7, bytes, 2); if (rc) return(rc); b = bytes[0] | (bytes[1] << 8); if (b >= 32768) b -= 65536; printf("A=%d B=%d\n", a, b); return(0); }