view rvinterf/libprint/back_esc.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 6a0aa8d36d06
children
line wrap: on
line source

/*
 * The function implemented in this module prints a potentially-dirty string
 * into a buffer with C-style backslash escapes, including doubling of any
 * already-present backslashes.  The output buffer must be sized for up to
 * 4x expansion, plus the terminating NUL.
 */

#include <sys/types.h>
#include <ctype.h>
#include <stdio.h>

void
safe_print_trace(src, srclen, dest)
	u_char *src;
	char *dest;
{
	int i, c;
	char *dp;

	dp = dest;
	for (i = 0; i < srclen; i++) {
		c = src[i];
		switch (c) {
		case '\\':
			*dp++ = '\\';
			*dp++ = '\\';
			continue;
		case '\r':
			*dp++ = '\\';
			*dp++ = 'r';
			continue;
		case '\n':
			*dp++ = '\\';
			*dp++ = 'n';
			continue;
		}
		if (c >= ' ' && c <= '~')
			*dp++ = c;
		else if (c <= 7 && (i+1 == srclen || !isdigit(src[i+1]))) {
			sprintf(dp, "\\%d", c);
			dp += 2;
		} else {
			sprintf(dp, "\\x%02X", c);
			dp += 4;
		}
	}
	*dp = '\0';
}